Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing lxml by defusedxml #81

Open
fmigneault opened this issue Jun 12, 2019 · 3 comments
Open

Consider replacing lxml by defusedxml #81

fmigneault opened this issue Jun 12, 2019 · 3 comments
Labels

Comments

@fmigneault
Copy link
Contributor

Resolves multiple attack methods through XML:
https://pypi.org/project/defusedxml/#python-xml-libraries

Replacement seems relatively straighforward
https://pypi.org/project/defusedxml/#defusedxml

@cehbrecht
Copy link
Member

... I'm wondering why the security fix is not part of lxml itself.

@fmigneault
Copy link
Contributor Author

My understanding is that, depending on the underlying c++ lib version used to build the python package, some settings are available/added to disable the processing of potentially "dangerous" items, but default values of these settings are not the sames across versions. Therefore the build environment for which you pull the package will cause different behaviours.

@fmigneault
Copy link
Contributor Author

Same fix as pywps, OWSLib, Weaver should be applied here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants