Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow review of storage requests that were not submitted #35

Open
mzur opened this issue Jul 4, 2024 · 1 comment · May be fixed by #51
Open

Don't allow review of storage requests that were not submitted #35

mzur opened this issue Jul 4, 2024 · 1 comment · May be fixed by #51
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mzur
Copy link
Member

mzur commented Jul 4, 2024

The storage request controller shows only requests that were not approved yet but it does not hide requests that were not submitted. Requests that were not submitted should not be shown by the controller. Fix this and add an appropriate test case.

@mzur mzur added bug Something isn't working good first issue Good for newcomers labels Jul 4, 2024
@mzur mzur moved this to Medium Priority in BIIGLE Roadmap Jul 4, 2024
@mzur
Copy link
Member Author

mzur commented Jul 24, 2024

The tests are here. It also includes an example for a 404 response when the storage request was already reviewed. The same should be expected for a storage request that was not submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Medium Priority
Development

Successfully merging a pull request may close this issue.

2 participants