-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation of new storage disks #4
Comments
The validation could be done with the created user disk here: and here: If the validation failed, the changes should be reverted. The validation can probably only be done after the disk is created because it needs an ID to create the "temporary storage disk", so the validation cannot be done in the form request classes. |
There was this error with an incorrectly entered endpoint URL (missing the bucket name):
Errors like these should produce a meaningful error message to the user, too (e.g. "access denied" in this case). |
We had an error
Unable to list contents
for an S3 disk. Maybe there was a typo in the URL. We should add a validation with a "list contents" call to check if any files can be listed with a new storage disk. If not, throw a vaildation error.The text was updated successfully, but these errors were encountered: