Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change notifications support for Bibles with dots in their name #968

Open
teusbenschop opened this issue Aug 28, 2024 · 0 comments
Open
Assignees

Comments

@teusbenschop
Copy link
Member

teusbenschop commented Aug 28, 2024

Currently if there's a Bible with a dot "." in its name, and there are change notifications for that, these don't get generated.

    std::vector <std::string> bits = filter::strings::explode (file, '.');
    if (bits.size() != 3) continue;

Additionally if the name starts with a ', it won't work either.

See the attached file for examples of that.

modifications.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant