Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing features from Indonesian to mainstream Bibledit and vice versa #886

Closed
teusbenschop opened this issue Mar 15, 2023 · 4 comments
Closed
Assignees

Comments

@teusbenschop
Copy link
Member

This issue is to keep track of, and discuss new features built for the Indonesian version of Bibledit, whether such features can be moved to mainstream Bibledit, or kept in the Indonesian Bibledit only.

This issue also is to keep track of removing features for previous versions of the Indonesian Cloud, features no longer in use. These features should be removed to keep Bibledit clean and tidy, and so to make it easier to maintain Bibledit.

The following three previous versions of the Indonesian Cloud have been found in the code:

bool indonesian_cloud_free ();
bool indonesian_cloud_free_simple ();
bool indonesian_cloud_free_individual ();
@oreowarpok
Copy link

I agree totally that the Indonesian_cloud_free things should be removed from Bibledit. As far as I know, we aren't even using those things now in our Indonesian Member BE.

I am satisfied with the things we have in place now. I can set up default resources for new users. And new Guest users automatically advance to Members (which is not a change). Aranggi has added a setting for giving new Members a default list of privileges. I think that is not currently working.

@aranggitoar
Copy link
Contributor

I agree totally that the Indonesian_cloud_free things should be removed from Bibledit. As far as I know, we aren't even using those things now in our Indonesian Member BE.

That's right.

This issue also is to keep track of removing features for previous versions of the Indonesian Cloud, features no longer in use. These features should be removed to keep Bibledit clean and tidy, and so to make it easier to maintain Bibledit.

I've just removed almost all of the features for Indonesian Bibledit. Though there are two few features that we might want to port into regular Bibledit, such as the email content setup in the other thread and maximum resource count setup. I'll open a thread for the second feature.

@aranggitoar aranggitoar self-assigned this Mar 16, 2023
@teusbenschop
Copy link
Member Author

Happy to hear that you both agree that things no longer in use can be removed.

Happy too @aranggitoar that you have already removed almost all of that, nice work.

@teusbenschop
Copy link
Member Author

Some code was added to enable functions to move to the Indonesian Member Cloud configuration, and so no be available in the mainstream Bibledit configuration. The next commit related to this issue will shows this code. It means one can put a file called indonesianmembercloud in the config folder to enable that configuration.

teusbenschop added a commit that referenced this issue May 1, 2023
teusbenschop added a commit that referenced this issue May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants