Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to async-std v1.13 #812

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Sep 7, 2024

No description provided.

Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a security reason or otherwise to require the newer version rather than allow this to work for people who are (for whatever reason) on an older version?

@jayvdb
Copy link
Contributor Author

jayvdb commented Sep 8, 2024

There are no relevant CVEs.

However, is there a security problem somewhere in async-std v1.9, 3.5 years ago, and its deps?

I'd put good money on it.

There are 133 commits in async-rs/async-std@v1.9.0...main

Anyway, feel free to close if you feel this PR doesnt improve criterion.

@jayvdb
Copy link
Contributor Author

jayvdb commented Sep 8, 2024

fwiw, criterion has a MSRV of 1.70 #813 , while async-std is 1.63 async-rs/async-std#1087

@waywardmonkeys
Copy link
Contributor

Seems fine to merge to me. Up to @bheisler though.

@waywardmonkeys
Copy link
Contributor

I meant to tag @lemmih here...

Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lemmih lemmih merged commit 58130ff into bheisler:master Oct 20, 2024
@jayvdb jayvdb deleted the update-async-std branch October 20, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants