Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARDEN_INVALID_TOKEN_MESSAGE not being rendered when token is invalid and Doorkeeper strategy fails #15

Open
pjmartorell opened this issue Dec 2, 2019 · 0 comments

Comments

@pjmartorell
Copy link

pjmartorell commented Dec 2, 2019

There is a bug in:

def invalid_token
fail!(WARDEN_INVALID_TOKEN_MESSAGE)
throw :warden
end

Just as a record, warden < 1.2.8 does NOT set the winning_strategy when :warden is thrown. As a consequence, warden_message in DoorkeeperFailureApp is always empty:

def oauth_error?
warden_message == Devise::Strategies::Doorkeeper::WARDEN_INVALID_TOKEN_MESSAGE
end

This issue in warden was solved in master in this PR: wardencommunity/warden#175
Dependencies should be updated as soon as there is a new release of warden in order to fix this issue. For now you can manually install warden in your Gemfile pointing to master or any revision after the fix above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant