Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the last PR merge.
I think there were some things missing, e.g. that I upaded the README to reflect the latest changes.
I tried to do that here.
All changes should be backwards compatible, so a 0.6.1 release would do it, however I leave the release decision (whether and if so, how) to you.
I applied all cargo clippy lints, and they are now also checked for the whole repo. ( if found now workaround other than ![allow(clippy::empty_docs)], because the doc comment comes from an imported crate, via the Parser macro :/ )
Note regarding the
license
. I modified the Cargo.toml to showMIT
as that is what the license-file currently contains.crates.io does not inspect the file itself, but just shows
non-standard
whenlicense-file
is used.You might also consider to re-license your crate under dual
MIT or Apache-2.0
, e.g. like crates like https://github.com/dtolnay/syn do. Its what most rust projects (and rust Itself choose): https://www.rust-lang.org/policies/licenses