Game can't end unless a human wins [GH-2]

[ben-ryder]

Describe the bug
If all human players die, the game does not end and the last surviving player must keep clicking through the next turn message as the computer players continue.
If a computer player wins, the game will not end but will continue. This is because the check for player death is done in the conquer handling in the view which the computer player doesn't invoke.

To Reproduce
All human players must be conquered, and a computer player must then conquer all other players.

Expected behaviour
When a computer player wins, the game should end and there should be the appropriate message.
When all human players die but computer players remain, this could be handled in multiple ways.

• The game could end with a defeated message.
• The next turn message continues each turn cycle but the text changes to reflect that they are simply viewing the game unfold now.
• The last player has a choice to keep watching the game by clicking through each turn cycle or to end the game.

System Information (please complete the following information):
n/a (This is a code bug/issue)

Additional context
n/a

[ben-ryder]

I've now created a game save which can be used to reproduce this issue. See issue 11 reproduction.zip.

It looks like the exact issue behavior has changed since this issue was first raised:

and the last surviving player must keep clicking through the next turn message as the computer players continue.

This is no longer accurate. What happens now is that the next turn message for the last surviving human stays on the screen and the game freezes. The backend then runs though the rest of the game (computers only) in the background. When the game is over and there is one surviving computer player, the UI updates again and the game over message is displayed.

[ben-ryder]

I'm going to look to fix this by implementing option one where the game will end with a different game over message.
This will probably work similar to the current game over message handling, but will instead be triggered when there are no human players left.

[ben-ryder]

This should now be fixed and this issue should no longer block work on GH-2.