StandaloneTestStrategy: add lcov_merger to tools of TestRunner spawns #24406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default lcov_merger (@bazel_tools//tools/test:lcov_merger) is a java_binary that requires runfiles to work. In StandaloneTestStrategy, it was added to the inputs of TestRunner spawns, but not to tools. This prevents the runfiles from being available to the action, preventing coverage to be collected during remote execution. Fixes bazelbuild#4033
github-actions
bot
added
team-Configurability
|
I just retested this on Bazel 8.0.0rc2 and later and noticed that this fix is no longer needed. |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default lcov_merger (@bazel_tools//tools/test:lcov_merger) is a java_binary that requires runfiles to work.
In StandaloneTestStrategy, it was added to the inputs of TestRunner spawns, but not to tools.
This prevents the runfiles from being available to the action, preventing coverage from being collected during remote execution.
Fixes #4033