Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show which OS a module supports #52

Open
alexeagle opened this issue Jan 18, 2023 · 1 comment
Open

Show which OS a module supports #52

alexeagle opened this issue Jan 18, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@alexeagle
Copy link
Contributor

Related to #29
We should show which platforms a module is tested on.

We'd have to parse the presubmit.yml for a line like https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/aspect_rules_js/1.15.1/presubmit.yml#L4

In particular, we should highlight when a module isn't tested on Windows, see bazelbuild/bazel-central-registry#282 (comment)

@hobofan
Copy link
Member

hobofan commented May 4, 2023

Noting down some info, as I took a quick look at it, and as always there seem to be a few nitty-gritty details that need to be figured out.

There seem to be multiple formats on how a platform can be specified. Apart from the matrix, the platform key can also appear in other positions (somewhat documented here https://github.com/bazelbuild/continuous-integration/tree/5242a5978f9a5219620813e0c540fb37444153ab/buildkite#legacy-format)

However, as it comes to testing, it seems that only the bcr_test_module.matrix.platform array values are relevant, if I understand it correctly.

For displaying the platform names, the emoji-name field may be usable (even though it contains some verbose platform info that I think may be too much detail for the BCR UI). We'll have to see how the emojis can be rendered (https://github.com/buildkite/emojis should help here, but the package is not published to NPM).


General docs about the presubmit.yml: https://github.com/bazelbuild/continuous-integration/tree/master/buildkite#configuring-a-pipeline

List of possible platform keys: https://github.com/bazelbuild/continuous-integration/blob/5242a5978f9a5219620813e0c540fb37444153ab/buildkite/bazelci.py#L461

@hobofan hobofan added the enhancement New feature or request label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants