This repository has been archived by the owner on May 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 437
Withdrawal safety for all key L2->L1 events #186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epociask
requested review from
adrain-cb,
sagrawal87,
nadir-akhtar-coinbase and
awilliams1-cb
November 9, 2023 00:07
adrain-cb
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, lets get this rebased and merged!
Review Error for adrain-cb @ 2024-02-06 02:57:51 UTC |
adrain-cb
previously approved these changes
Feb 6, 2024
cb-heimdall
dismissed
adrain-cb’s stale review
February 26, 2024 22:32
Approved review 1866137561 from adrain-cb is now dismissed due to new commit. Re-request for approval.
megha31-cb
approved these changes
Feb 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Withdrawal safety for all key L2->L1 events
Fixes Issue
Fixes #178
Changes proposed
WithdrawalFinalized
eventsScreenshots (Optional)
Note to reviewers