Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check mount point before mounting in entry.sh entry script #781

Open
nghiant2710 opened this issue Jul 12, 2022 · 2 comments
Open

Check mount point before mounting in entry.sh entry script #781

nghiant2710 opened this issue Jul 12, 2022 · 2 comments

Comments

@nghiant2710
Copy link
Contributor

Balena supervisor will bind mount the host OS /sys into the container if label io.balena.features.sysfs is set so customer might see some error like this mount: /sys/kernel/debug: nodev already mounted or mount point busy. in the logs if both UDEV and the label above is set.

The entry script should check the mount point before mounting to avoid this conflict.

@jellyfish-bot
Copy link

jellyfish-bot commented Aug 16, 2022

I have been using a custom script for USB mounting and incorporated a fix for this issue in it. The hope is to try it out for a while and check it is effective and causes no issues. The new version has also converted from the original BASH in to SH which should remove the requirement of installing bash in to Alpine containers to run the script: balena-io-experimental/starter-interface@23119f9

@jellyfish-bot
Copy link

[maggie0002] We may also want to consider using install_packages to install udev and other package requirements rather than including them in the image by default. It wouldn't work offline but we could return an error notifying the user of the packages they should include for offline use. This reduces the image size, I tend to aim for as little in the images as possible and let people build up from there, as there isn't a good way to remove things we add in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants