Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actual full gem downloads number? #1534

Closed
AlphaDaniel opened this issue Feb 28, 2018 · 7 comments
Closed

Actual full gem downloads number? #1534

AlphaDaniel opened this issue Feb 28, 2018 · 7 comments
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas

Comments

@AlphaDaniel
Copy link

Is it possible to show the full number of downloads instead of rounding. I came across ruby-gem-downloads-badge which was built off of this repo and it displays full

but it seems to have caching issues where after I guess the initial request following requests do not get to the application and the badge never changes.

Would be awesome if had an option with shields.io, added to the other gem downloads options, where it can display exact number.

@RedSparr0w
Copy link
Member

RedSparr0w commented Feb 28, 2018

related - #999 - #742

@RedSparr0w RedSparr0w added the core Server, BaseService, GitHub auth, Shared helpers label Feb 28, 2018
@AlphaDaniel
Copy link
Author

AlphaDaniel commented Feb 28, 2018

Oh ok so that was for stars... is the request for gem the same?

Just seen it was already done here and looks perfect would it not be possible to add this option to gem downloads?

My original request was for a simple additional extra option for gem downloads badges not all so in theory

11
Gem:

https://img.shields.io/gem/dt/rails.svg?type=total

I understand the issue of consistency in my honest opinion shields already has 3 different flavors of displaying gem downloads ....stable, latest, etc.. what have you. Though those are different (I understand) being that it's different data and this would be same data as total metric but with a different format.... again (imo) think could be thought of as just one more flavor.

These badges were made for quick access to information and I just don't see how it can hurt for that info to be exact vs rounded.

That being said I do understand the snowball effect this might have on your side as devs and I'm sure you might have additional reasons but thought I'd share all my thoughts on it in full.

Disclaimer: I am new to developing so please bear with any naiveté on my part lol if there is any in this reply

@RedSparr0w
Copy link
Member

Hey, sorry about the short reply (was on mobile and haven't had much time on this project lately), Just thought i would quickly link some relevant post in case something happened in those which affected this or vice versa.

As this would be quite a big change it would have to be approved by @paulmelnikow and or @espadrine.

As per this comment:

My question is still this:

This request is for https://github.com/mingrammer/go-web-framework-stars. If the Shields badge designs were integrated into that page, how would it look?

If anyone would like to mock something up (using static badges, say), I'd be happy to consider it.

I think creating a few mockups would be the best place to start.

@AlphaDaniel
Copy link
Author

AlphaDaniel commented Mar 2, 2018

Hey thanks for replying and hmm so weird didn't get an email would've replied sooner. As far as the mock up goes, I'd see it looking exactly as bogdanRada did it. See below

@bogdanRada figure I'd @ since referencing your repo

@bogdanRada
Copy link
Contributor

Hello. I believe we already discussed this when I submitted this pull request. #212.

If I remember correctly the decision was to keep it consistent and that code was removed in this commit d42a7162de4bb594e7618a06f9fb37636d5b909cI do like very much this idea however. If I remember correctly we had same problem with other badges that we didn't know how to handle them.

I just wanted to say this in case it makes sense. I am very excited about this possible feature. Please do let me know if I can help in any way 😁

@paulmelnikow
Copy link
Member

Project Name Stars –––––––––––––– Forks Open Issues Description
gin 1786 189 Gin is a HTTP web framework written in Go (Golang). It features a Martini-like API with much better performance -- up to 40 times faster. If you need smashing performance, get yourself some Gin.
beego 3153 443 beego is an open-source, high-performance web framework for the Go programming language.
martini 1042 1 ⚠️ No longer maintained ⚠️ Classy web framework for Go
echo 814 98 High performance, minimalist Go web framework

Another promising start:

Project Name Popularity Description
echo High performance, minimalist Go web framework

Obviously there are some formatting issues there. Maybe we could take this as a starting point and design something really nice using a new badge template. That might be a bit of work, but I think it could have really good payoff for the number of projects that might use it. The various awesome lists come to mind, and in fact using shields for awesome lists is what initially drew me. Compared with having one badge per column, I like this approach because it's only one badge to cache per project and also 1/3 the number of requests when that page gets loaded.

@paulmelnikow paulmelnikow mentioned this issue Jan 4, 2019
10 tasks
@paulmelnikow paulmelnikow added question Support questions, usage questions, unconfirmed bugs, discussions, ideas and removed core Server, BaseService, GitHub auth, Shared helpers labels Jan 8, 2019
@paulmelnikow
Copy link
Member

We're working on a combo badge in #2678, and have just launched the Endpoint badge to support any kind of custom logic. If you decide to use the endpoint badge, your feedback is much appreciated! Please feel free to comment on the Endpoint beta issue if you have feedback or questions about how to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas
Projects
None yet
Development

No branches or pull requests

4 participants