Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub file size badge doesn't work for some files #10548

Open
chris48s opened this issue Sep 21, 2024 · 2 comments
Open

GitHub file size badge doesn't work for some files #10548

chris48s opened this issue Sep 21, 2024 · 2 comments
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs

Comments

@chris48s
Copy link
Member

chris48s commented Sep 21, 2024

Are you experiencing an issue with...

shields.io

🐞 Description

This badge works for most files
https://img.shields.io/github/size/badges/shields/server.js
but there are some that cause a problem
https://img.shields.io/github/size/badges/shields/package.json
The reason this fails is because this causes us to look for a file called "package" and use json output format, rather than look for a file called "package.json"

🔗 Link to the badge

https://img.shields.io/github/size/badges/shields/package.json

💡 Possible Solution

We might need to switch path from a path param to a query param to solve this.

@chris48s chris48s added question Support questions, usage questions, unconfirmed bugs, discussions, ideas bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs and removed question Support questions, usage questions, unconfirmed bugs, discussions, ideas labels Sep 21, 2024
Copy link
Contributor

Badge tested using npm run badge https://img.shields.io/github/size/badges/shields/package.json
Output is available here

@chris48s
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

No branches or pull requests

1 participant