Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
As a somewhat heavy user of
gitcheck
I regularly found that the "first check of the day" took rather long. Turns out that themaxdepth
parameter was not applied to the actual traversal but only the output.This PR is a proposal to change that behaviour. It is especially useful when having "cold storage" like after a system restart.
For reference I have measured some timings for my system (the separate number is the number of directories check if it is a git repository).
Your mileage obviously varies as both the directory count and timings depend on the type of disk used but it should generally be faster.