Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage in GCS #827

Closed
wants to merge 6 commits into from
Closed

Storage in GCS #827

wants to merge 6 commits into from

Conversation

lauramorillo
Copy link

@lauramorillo lauramorillo commented Jan 3, 2017

Implemented the connection to use Google Cloud Storage with the XML API and the Interoperable storage access keys using the fog gem already included in the project.

I have tested it using Ruby 2.3.3p222 on Mac OS

Closes backup/backup-features#22

@tombruijn
Copy link
Member

Hi @lauramorillo !

Thanks for the PR. This looks awesome!
I didn't know fog started supporting Google.

Let me check it out at a later time, I'll want to test it manually myself as well :)

It's probably going to be part of a major version release we're sort of working on. In #807 we're also trying to add integration tests for everything again so this would be a good one to test right away.

Oh and sorry for the new linter rules 😅

@tombruijn tombruijn self-assigned this Jan 8, 2017
@lauramorillo
Copy link
Author

Thanks @tombruijn! Just let me know if I can help with anything else! And don't worry for the linter rules, it is nice to have them as a guide when writing code for a different project! :D

@jason-riddle
Copy link

Any update on this by chance?

@tombruijn
Copy link
Member

Nope. Would have commented if so. Haven't gotten around to doing anything for backup recently. Hope to change that soon

@Uysim
Copy link

Uysim commented Oct 19, 2018

Anychance this will ber merged?

@Roko131
Copy link
Contributor

Roko131 commented Aug 22, 2019

Problem with deleting bucket objects (solved):

Merged into 5.0.0.beta.2.
Stated keep = 3 so on the 4rd backup- It tried to delete the first backup (as it should) but failed with undefined method 'delete' for #<Fog::Storage::Google::Real>.
Failed since the google API call name is delete_object, not delete.

To fix:
At lib/backup/cloud_io/gcs.rb inside delete method (line 72)- need to change connection.delete(bucket, key) to connection.delete_object(bucket, key).

@elthariel
Copy link
Contributor

Hi @lauramorillo @jason-riddle @Roko131. I'm the new maintainer of the projet and I'm willing to give this PR a look if you can rebase it.

Also, look at our new CONTRIBUTING.md, it's become much easier to become a maintainer.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Google Cloud Storage / nearline to storages
6 participants