Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Application Signals export template #1430

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Unify Application Signals export template #1430

merged 2 commits into from
Dec 4, 2024

Conversation

bjrara
Copy link
Collaborator

@bjrara bjrara commented Nov 15, 2024

Description of the issue

We miss the use case where customers want to send metrics with RemoteEnvironment dimension on non Kubernetes based platforms. This PR unifies the template file to allow customers to customize their metrics to add RemoteEnvironment.

Description of changes

Unify the EMF export template in Application Signals.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Describe what tests you have done.

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@bjrara bjrara requested a review from a team as a code owner November 15, 2024 19:27
@bjrara bjrara force-pushed the main branch 2 times, most recently from b1c8c08 to 7ef7653 Compare November 21, 2024 17:24
mxiamxia
mxiamxia previously approved these changes Nov 21, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Dec 2, 2024
lisguo
lisguo previously approved these changes Dec 4, 2024
@sky333999 sky333999 merged commit 6856538 into aws:main Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants