Skip to content

Commit

Permalink
fix: do not delete explore user when pipeline versions contain v1.1.4 (
Browse files Browse the repository at this point in the history
  • Loading branch information
tyyzqmf authored Mar 7, 2024
1 parent 2b2bbe9 commit 4a22000
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/control-plane/backend/lambda/api/service/reporting.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1082,7 +1082,7 @@ async function _cleanUser() {

function _needExploreUserVersion(pipeline: IPipeline) {
const version = pipeline.templateVersion?.split('-')[0] ?? '';
const oldVersions = ['v1.1.0', 'v1.1.1', 'v1.1.2', 'v1.1.3'];
const oldVersions = ['v1.1.0', 'v1.1.1', 'v1.1.2', 'v1.1.3', 'v1.1.4'];
return oldVersions.includes(version);

}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1211,7 +1211,7 @@ describe('reporting test', () => {
expect(quickSightMock).toHaveReceivedCommandTimes(DeleteUserCommand, 1);
});

it('clean - include v1.1.3 pipeline', async () => {
it('clean - include v1.1.4 pipeline', async () => {

quickSightMock.on(ListDashboardsCommand).resolves({
DashboardSummaryList: [{
Expand Down Expand Up @@ -1274,7 +1274,7 @@ describe('reporting test', () => {

ddbMock.on(QueryCommand).resolves({
Items: [
{ templateVersion: 'v1.1.3' },
{ templateVersion: 'v1.1.4' },
{ templateVersion: 'v1.2.0' },
],
});
Expand Down

0 comments on commit 4a22000

Please sign in to comment.