Invalid endpoint in badge url when region is us-east-1

[lorengordon]

s3-us-east-1 is not a valid S3 endpoint.

aws-codecommit-pull-request-aws-codebuild/base-layer.yaml

Lines 190 to 197 in 397e07b

	for phase in event['detail']['additional-information']['phases']:
	if phase.get('phase-status') == 'FAILED':
	badge = 'https://s3-{0}.amazonaws.com/codefactory-{0}-prod-default-build-badges/failing.svg'.format(event['region'])
	content = ' - See the [Logs]({1})'.format(badge, event['detail']['additional-information']['logs']['deep-link'])
	break
	else:
	badge = 'https://s3-{0}.amazonaws.com/codefactory-{0}-prod-default-build-badges/passing.svg'.format(event['region'])
	content = ' - See the [Logs]({1})'.format(badge, event['detail']['additional-information']['logs']['deep-link'])

See:

https://docs.aws.amazon.com/general/latest/gr/rande.html#s3_region

[lorengordon]

Well, may be immaterial, since CodeCommit (in us-east-1) does not resolve the image links anyway.

[j0lly]

Hi @lorengordon thanks for reaching out with this.
You right, the s3 dns naming will breaks in us-east-1, let me change that.
As per your second comment, do you mind explaining what you did and what is not working?

Thanks,