Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quicksight automation with CDK - I did it and want to contribute it to the examples #870

Open
1 of 2 tasks
gmournos opened this issue Jun 28, 2023 · 5 comments
Open
1 of 2 tasks
Labels
feature-request A feature should be added or improved. language/typescript Related to Typescript examples p2

Comments

@gmournos
Copy link

Describe the feature

Hi,

I wrote an article to help the community to automate Quicksight assets generation (https://medium.com/@gmournos/aws-quicksight-as-code-a-unified-approach-for-quicksight-development-and-deployment-using-aws-30bbb6bd253a) and created a public repo (https://github.com/gmournos/quicksight-as-code) that automates the generation of the AWS samples provided by Quicksight.

I would like to contribute it here...

Use Case

Deploying Quicksight with CDK is a much better approach than the ones proposed by AWS, using cross account templates. For a full list of benefits, look at section 1.1. of my article (https://medium.com/@gmournos/aws-quicksight-as-code-a-unified-approach-for-quicksight-development-and-deployment-using-aws-30bbb6bd253a)

Proposed Solution

I already implemented everything in https://github.com/gmournos/quicksight-as-code, I just want to contribute it here.

The solution is a unified approach, containing L2 constructs, CLI scripts, utilities etc as described in my article (https://medium.com/@gmournos/aws-quicksight-as-code-a-unified-approach-for-quicksight-development-and-deployment-using-aws-30bbb6bd253a)

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

Language

Typescript

@gmournos gmournos added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 28, 2023
@ericzbeard ericzbeard removed the needs-triage This issue or PR still needs to be triaged. label Jul 14, 2023
@ericzbeard
Copy link
Contributor

Looks great, let's do it. I've done a bit of QuickSight development and automation/repeatability has been a struggle. One request I have is to add as many code comments as you can - we want this repo to be a good data source for generative AI tools and it helps to have descriptive comments above code blocks.

@kaiz-io kaiz-io added language/typescript Related to Typescript examples p2 labels Oct 24, 2023
@sebs
Copy link
Contributor

sebs commented Jul 18, 2024

i guess we begin to sit on a example of quicksight/cdk code as well. Different usecase. We could provide a very basic example as well. If that is something that is in need.

@gmournos
Copy link
Author

Actually, I have a full framework for this. Forgot to contribute it, but I have some time this weekend, so I will comment it and contribute it.

@gmournos
Copy link
Author

And here is the PR [https://github.com//pull/1059].
Sorry for taking so long to contribute this. I forgot about it and thought I did it last year.

Happy reviewing

@sebs
Copy link
Contributor

sebs commented Oct 9, 2024

We are cooking a 'easy' example as well and maybe that more complex onw from @gmournos makes sense with it as context. We stuck to the basics and it should be as briefly as it can get.

https://github.com/MaibornWolff/aws-cdk-examples/tree/ts-quicksight-example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. language/typescript Related to Typescript examples p2
Projects
None yet
Development

No branches or pull requests

4 participants