Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated cloudfront_origins.S3Origin from static site example #1084

Open
zeekrey opened this issue Oct 9, 2024 · 0 comments · May be fixed by #1107
Open

Remove deprecated cloudfront_origins.S3Origin from static site example #1084

zeekrey opened this issue Oct 9, 2024 · 0 comments · May be fixed by #1107
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@zeekrey
Copy link

zeekrey commented Oct 9, 2024

Describe the bug

The static site example utilizes

origin: new cloudfront_origins.S3Origin(siteBucket, {originAccessIdentity: cloudfrontOAI}),

even though S3Origin is labeled as deprecated: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_cloudfront_origins.S3Origin.html

Expected Behavior

The example uses S3BucketOrigin or S3StaticWebsiteOrigin instead.

Current Behavior

Using the example triggers a deprecation warning.

Reproduction Steps

Checkout https://github.com/aws-samples/aws-cdk-examples/blob/main/typescript/static-site/static-site.ts and install latest deps.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.161.1

Framework Version

No response

Node.js Version

20.11.1

OS

macOS 14.6.1

Language

Typescript

Language Version

No response

@zeekrey zeekrey added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 9, 2024
@stenczelt stenczelt linked a pull request Dec 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant