Skip to content

Commit

Permalink
Use skips instead of custom mark
Browse files Browse the repository at this point in the history
  • Loading branch information
tstirrat15 committed Sep 3, 2024
1 parent 487369b commit 5a5f2ea
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
5 changes: 1 addition & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,10 @@ ignore_missing_imports = true
module = ["google.rpc.*", "grpcutil"]

[tool.pytest.ini_options]
addopts = "-x -m \"not remote_calls\""
addopts = "-x"
log_level = "debug"
minversion = "6.0"
asyncio_mode = "auto"
markers = [
"remote_calls: marks tests that make remote calls, not normally run"
]

[tool.isort]
ensure_newline_before_comments = true
Expand Down
6 changes: 3 additions & 3 deletions tests/insecure_client_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,21 @@
remote_host = "192.168.something.something"


@pytest.mark.remote_calls
@pytest.mark.skip(reason="Makes a remote call that we haven't yet supported in CI")
async def test_normal_async_client_raises_error_on_insecure_remote_call(token):
with pytest.raises(grpc.RpcError):
client = AsyncClient(f"{remote_host}:50051", insecure_bearer_token_credentials(token))
await write_test_schema(client)


@pytest.mark.remote_calls
@pytest.mark.skip(reason="Makes a remote call that we haven't yet supported in CI")
async def test_normal_sync_client_raises_error_on_insecure_remote_call(token):
with pytest.raises(grpc.RpcError):
client = SyncClient(f"{remote_host}:50051", insecure_bearer_token_credentials(token))
await write_test_schema(client)


@pytest.mark.remote_calls
@pytest.mark.skip(reason="Makes a remote call that we haven't yet supported in CI")
async def test_insecure_client_makes_insecure_remote_call(token):
insecure_client = InsecureClient(f"{remote_host}:50051", token)
await write_test_schema(insecure_client)

0 comments on commit 5a5f2ea

Please sign in to comment.