Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARO Coding Standards? #4

Open
mf790v opened this issue Feb 10, 2013 · 0 comments
Open

ARO Coding Standards? #4

mf790v opened this issue Feb 10, 2013 · 0 comments

Comments

@mf790v
Copy link

mf790v commented Feb 10, 2013

Which coding standard(s) does ARO follow??

Analyzing the source code of ARO using v.12 of the Intellij IDE points out these errors (among others):

  1. Coding Style
    1. ARO Doesn't Follow Basic Java Style
      1. C-style array declaration
      2. Missorted modifiers
      3. Pointless bitwise expression
      4. Confusing floating-point literal
      5. Assignment replaceable with operator assignment
    2. ARO Follows Java Style Older Than The Minimum Version To Built It
      1. Missing @OverRide annotation
      2. Unnecessary boxing
      3. Unnecessary unboxing
      4. 'while' loop replaceable with 'for each'
      5. 'for' loop replaceable with 'for each'
      6. Use of obsolete collection type
      7. Use of System.out or System.err
    3. Which Coding Style? (ARO Does Both Possible Choices, Where Either Choice, But Not Both, Is A Coding Standard)
      1. Mark an item as 'final'??
        1. 'final' class
        2. 'final' method
        3. 'static', non-'final' field
        4. Field may be final
        5. Unnecessary 'final' on local variable or parameter
        6. Local variable or parameter can be final
      2. Implicit vs. Explicit Code, Prefer Which?
        1. Unnecessarily qualified static access
        2. Unqualified static access
        3. Unnecessarily qualified inner class access
        4. Unqualified inner class access
        5. This
          1. Unnecessary 'this' qualifier
          2. Unnecessary qualifier for 'this'
          3. Instance field access not qualified with 'this'
          4. Instance method call not qualified with 'this'
        6. Super
          1. Implicit call to 'super()'
          2. Unnecessary 'super' qualifier
          3. Unnecessary call to 'super()'
      3. Constant on Right or Left Side of Boolean Condition?
        1. Constant on left side of comparison
        2. Constant on right side of comparison
      4. Conditional Expressions
        1. Conditional expression (?:)
        2. 'if' statement could be replaced with conditional expression
    4. Information Hiding
      1. Anonymous class variable hides variable in containing method
      2. Inner class field hides outer class field
      3. Local variable hides field
      4. Method overrides private method of superclass
      5. Parameter hides field
  2. Property File Problems
    1. Duplicate Property
    2. Trailing Spaces in Property
    3. Unused Property
  3. Performance
    1. Object allocation in loop
    2. Redundant 'String.toString()'
    3. 'size() == 0' replaceable with 'isEmpty()'
    4. 'indexOf()' expression is replaceable with 'contains()'
    5. Multiply or divide by power of two
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant