Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change function definitions to use &Q instead of &K #1

Open
asyncth opened this issue May 28, 2022 · 0 comments
Open

Change function definitions to use &Q instead of &K #1

asyncth opened this issue May 28, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@asyncth
Copy link
Owner

asyncth commented May 28, 2022

Change

pub fn get(&mut self, k: &K) -> Option<&V>

to

pub fn get<'a, Q>(&'a mut self, k: &Q) -> Option<&'a V>
    where
        KeyRef<K>: Borrow<Q>,
        Q: Hash + Eq + ?Sized,

like in SlruCache.

WTinyLfuCache was initially supposed to do that but I ran into some problems.
@asyncth asyncth added enhancement New feature or request help wanted Extra attention is needed labels May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asyncth