Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'dbt-core<1.8.9' pin #1371

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Remove 'dbt-core<1.8.9' pin #1371

merged 4 commits into from
Dec 10, 2024

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Dec 9, 2024

We were facing issues with conflicting dbt core and dbt-databricks when using the latest release of dbt-core:

File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line [940](https://github.com/astronomer/astronomer-cosmos/actions/runs/12018236731/job/33502297498?pr=1340#step:7:941), in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/runner/.local/share/hatch/env/virtual/astronomer-cosmos/Za_bFbg4/tests.py3.11-2.6/lib/python3.11/site-packages/dbt/adapters/databricks/__init__.py", line 1, in <module>
    from dbt.adapters.databricks.connections import DatabricksConnectionManager  # noqa
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/.local/share/hatch/env/virtual/astronomer-cosmos/Za_bFbg4/tests.py3.11-2.6/lib/python3.11/site-packages/dbt/adapters/databricks/connections.py", line 27, in <module>
    from dbt.adapters.base import Credentials
ImportError: cannot import name 'Credentials' from 'dbt.adapters.base' (/home/runner/.local/share/hatch/env/virtual/astronomer-cosmos/Za_bFbg4/tests.py3.11-2.6/lib/python3.11/site-packages/dbt/adapters/base/__init__.py)

This PR solves this.

Closes: #1343

Copy link

cloudflare-workers-and-pages bot commented Dec 9, 2024

Deploying astronomer-cosmos with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7c18bf4
Status: ✅  Deploy successful!
Preview URL: https://5be3b37c.astronomer-cosmos.pages.dev
Branch Preview URL: https://issue-1343.astronomer-cosmos.pages.dev

View logs

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (c606bcb) to head (7c18bf4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1371   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files          67       67           
  Lines        4025     4025           
=======================================
  Hits         3865     3865           
  Misses        160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana tatiana changed the title WIP: Remove 'dbt-core<1.8.9' pin Remove 'dbt-core<1.8.9' pin Dec 9, 2024
.github/workflows/test.yml Outdated Show resolved Hide resolved
@tatiana tatiana marked this pull request as ready for review December 9, 2024 16:55
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area:dependencies Related to dependencies, like Python packages, library versions, etc labels Dec 9, 2024
@tatiana tatiana merged commit 0951f27 into main Dec 10, 2024
64 checks passed
@tatiana tatiana deleted the issue-1343 branch December 10, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependencies Related to dependencies, like Python packages, library versions, etc size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable tests for dbt-core-1.8.9
2 participants