Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency eval_type_backport #1370

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Remove dependency eval_type_backport #1370

merged 1 commit into from
Dec 9, 2024

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Dec 9, 2024

Sometimes, time is the best medicine. The CI issue that happened before no longer occurs, and we can remove the dependency eval_type_backport while seeing all the tests pass.

Closes: #1342

@tatiana tatiana changed the title [WIP] Remove dependency eval_type_backport Remove dependency eval_type_backport Dec 9, 2024
@tatiana tatiana marked this pull request as ready for review December 9, 2024 09:26
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area:dependencies Related to dependencies, like Python packages, library versions, etc labels Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (3ff70d8) to head (a281e50).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1370   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files          67       67           
  Lines        4025     4025           
=======================================
  Hits         3865     3865           
  Misses        160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana tatiana merged commit c606bcb into main Dec 9, 2024
64 checks passed
@tatiana tatiana deleted the issue-1342 branch December 9, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependencies Related to dependencies, like Python packages, library versions, etc size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency eval_type_backport from tests
2 participants