Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tip: send emails with #15

Open
florian-lefebvre opened this issue Dec 1, 2023 · 10 comments
Open

New tip: send emails with #15

florian-lefebvre opened this issue Dec 1, 2023 · 10 comments
Labels

Comments

@florian-lefebvre
Copy link
Member

No description provided.

@OliverSpeir
Copy link
Collaborator

I did write this

https://oliverspeir.dev/garden/nodemailer/

might be somewhat useful, it's kind of a mess and I've been meaning to polish it up.

It's lacking the (adapter specific) server/hybrid approach of not having the serverless function be separate but instead an api endpoint ( only works on vercel and netlify serverless )

Could be useful to whoever takes on this issue though

@florian-lefebvre
Copy link
Member Author

Maybe this tip could be reworked as: "Sending emails with Astro". Then we could add several popular methods: yours, nodemailer, resend (I have something ready already) etc

@alexanderniebuhr
Copy link
Member

"Sending emails with Astro"

I like that idea. That would maybe allow use to keep sections the same, and then use maybe something like a tab component to allow the user to switch between solutions 🤔

@florian-lefebvre
Copy link
Member Author

Either this or one h2 per tech + same substeps (if possible) for each. If we go the tabs way, it would be great that switching one tab switches all of them (eg. You select resend at first, you want all the tabs to be for resend)

@alexanderniebuhr
Copy link
Member

From the UX perspective, I'd definitely prefer the tab solution (or something similar e.g. https://moonrepo.dev/docs/setup-toolchain, has a select drop-down in the top-right)

But if that is to complex to implement for now I also think headings could also work.

@florian-lefebvre
Copy link
Member Author

florian-lefebvre commented Mar 18, 2024

Let's ask the experts! @HiDeoo @TheOtterlord how hard is it to have synced tabs as explained in #15 (comment) ? Do you have such thing on Astro docs? Do you think one pattern is better than another and why?

@alexanderniebuhr
Copy link
Member

I just checked this https://docs.astro.build/en/install/auto/ and it seems like if I choose a package manager it is changed for the full page

@HiDeoo
Copy link
Member

HiDeoo commented Mar 18, 2024

Let's ask the experts! @HiDeoo @TheOtterlord how hard is it to have synced tabs as explained in #15 (comment) ? Do you have such thing on Astro docs? Do you think one pattern is better than another and why?

There is a pending PR for it but that will probably not land very soon.

Adding the syncing behavior through a custom component on top of the current Starlight component is not that difficult, that's what the docs are doing for example (ref), same for starlight-package-managers.

@florian-lefebvre
Copy link
Member Author

Gotcha thanks a lot!

@florian-lefebvre florian-lefebvre changed the title New tip: send emails with nodemailer New tip: send emails with Mar 28, 2024
@alexanderniebuhr alexanderniebuhr added the good first issue Good for newcomers label May 13, 2024
@florian-lefebvre
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants