Skip to content
GitHub Actions / clippy-all-features failed Jul 9, 2024 in 1s

clippy-all-features

3 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 3
Warning 0
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check failure on line 114 in crates/relayer-types/src/core/ics23_commitment/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-all-features

assigning the result of `Clone::clone()` may be inefficient

error: assigning the result of `Clone::clone()` may be inefficient
   --> crates/relayer-types/src/core/ics23_commitment/merkle.rs:114:21
    |
114 |                     value = subroot.clone();
    |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `value.clone_from(&subroot)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
    = note: `-D clippy::assigning-clones` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::assigning_clones)]`

Check failure on line 412 in crates/relayer-types/src/core/ics03_connection/connection.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-all-features

function cannot return without recursing

error: function cannot return without recursing
   --> crates/relayer-types/src/core/ics03_connection/connection.rs:410:5
    |
410 | /     fn from(value: State) -> Self {
411 | |         value.into()
412 | |     }
    | |_____^
    |
note: recursive call site
   --> crates/relayer-types/src/core/ics03_connection/connection.rs:411:9
    |
411 |         value.into()
    |         ^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unconditional_recursion
    = note: `-D clippy::unconditional-recursion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::unconditional_recursion)]`

Check failure on line 9 in crates/relayer-types/src/core/ics03_connection/connection.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-all-features

importing legacy numeric constants

error: importing legacy numeric constants
 --> crates/relayer-types/src/core/ics03_connection/connection.rs:9:5
  |
9 |     u64,
  |     ^^^
  |
  = help: remove this import
  = note: then `u64::<CONST>` will resolve to the respective associated constant
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
  = note: `-D clippy::legacy-numeric-constants` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::legacy_numeric_constants)]`