chore(sequencer-relayer): box large enum variant #1864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanoroshiba
added
sequencer-relayer
|
I'd honestly be fine with just slapping an |
|
Closing since this is in a test environment only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Boxed large error variant
Background
Large enum variants should be avoided since enums are as large as their largest variant: https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
Wasn't caught by clippy until running with Rust 1.83.0 in #1857.
Changes
Blockvariant ofSequencerBlockToMount.Testing
Passing all tests
Changelogs
No updates needed.
Breaking Changes
Overridden code freeze since this is a very small, non breaking change that shouldn't have any bearing since our previous audit.
Related Issues
closes #1859