Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequencer: remove unnecessary unwraps #1852

Open
ethanoroshiba opened this issue Dec 5, 2024 · 0 comments
Open

sequencer: remove unnecessary unwraps #1852

ethanoroshiba opened this issue Dec 5, 2024 · 0 comments
Assignees
@ethanoroshiba
Labels
code-quality sequencer pertaining to the astria-sequencer crate

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Dec 5, 2024 •
edited by sync-by-unito bot
Loading

Most instances of get_transaction_context are expected, creating unnecessary panic paths. While a lack of transaction context would likely result in the sequencer ceasing to work properly, we should find a way to remove these panic possibilities, such as what is mentioned here: #1850 (review).

┆Issue Number: ENG-1036
@ethanoroshiba ethanoroshiba added sequencer pertaining to the astria-sequencer crate code-quality labels Dec 5, 2024
@ethanoroshiba ethanoroshiba self-assigned this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanoroshiba ethanoroshiba

Labels
code-quality sequencer pertaining to the astria-sequencer crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ethanoroshiba