Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequencer: refactor code duplication in app::process_proposal #1835

Open
bharath-123 opened this issue Nov 25, 2024 · 0 comments
Open

sequencer: refactor code duplication in app::process_proposal #1835

bharath-123 opened this issue Nov 25, 2024 · 0 comments

Comments

@bharath-123
Copy link
Contributor

bharath-123 commented Nov 25, 2024 •
edited by sync-by-unito bot
Loading

In the app::process_proposal method, there are two branches(one for when the validator of the particular round calls process_proposal and one for when a non-validator calls process_proposal), both of these branches involve calls to post_execute_transactions which appears to be unnecessary code duplication. It is worth refactoring it in future PRs

┆Issue Number: ENG-1028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bharath-123