Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black box tests to composer to cover deleted internal tests #1652

Open
itamarreif opened this issue Oct 11, 2024 · 1 comment · May be fixed by #1834
Open

Add black box tests to composer to cover deleted internal tests #1652

itamarreif opened this issue Oct 11, 2024 · 1 comment · May be fixed by #1834
Labels
composer pertaining to composer testing

Comments

@itamarreif
Copy link
Contributor

itamarreif commented Oct 11, 2024

PR #1643 removes fragile tests that were internal to the composer crate as they were a maintenance burden.

The tests that are removed:

  1. full_bundle - This is covered by the unit tests in the bundle_factory module internal to the composer. Probably doesn't require adding a new black box test.
  2. bundle_triggered_by_block_timer - This test assumes quite a bit of knowledge about the internal functions of the composer (specifically that if the bundle isn't filled then it will be submitted after the block timer).
  3. two_seq_actions_single_bundle - A test similar to the existing single_rollup_tx_payload_integrity that has two transactions should be added to cover this.
  4. chain_id_mismatch_returns_error - Likely requires bubbling errors up and out from the composer service.

┆Issue Number: ENG-914

@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composer pertaining to composer testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants