Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local packse workflow #9808

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Fix local packse workflow #9808

merged 2 commits into from
Dec 11, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented Dec 11, 2024

Make the local packse workflow work again:

# In packse:
uv run --extra index --extra serve packse serve --no-hash scenarios &
# In uv:
UV_TEST_INDEX_URL="http://localhost:3141/simple/" ./scripts/scenarios/generate.py

Bugs fixed:

  • The default scenario pattern didn't match anything.
  • The snapshot update test command was wrong since the test centralization
  • Snapshot update failures would not be reported

Add `UV_TEST_INDEX_URL` and `UV_TEST_VENDOR_LINKS_URL` to allow testing with a temporary packse index. Previously, it was not possible to update the snapshots for the packse scenarios with a local packse version, it had to be merged and released into upstream packse first.
Make the local packse workflow work again:

```
# In packse:
uv run --extra index --extra serve packse serve --no-hash scenarios &
# In uv:
UV_TEST_INDEX_URL="http://localhost:3141/simple/" ./scripts/scenarios/generate.py
```

Bugs fixed:
* The default scenario pattern didn't match anything.
* The snapshot update test command was wrong since the test centralization
* Snapshot update failures would not be reported
@konstin konstin added the internal A refactor or improvement that is not user-facing label Dec 11, 2024
@konstin konstin requested a review from zanieb December 11, 2024 12:06
@zanieb zanieb merged commit cb3feff into main Dec 11, 2024
64 checks passed
@zanieb zanieb deleted the konsti/fix-packse-workflow branch December 11, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants