Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolver module improvements #9773

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Resolver module improvements #9773

merged 1 commit into from
Dec 11, 2024
+84 −64

Conversation

konstin
Copy link
Member

@konstin konstin commented Dec 10, 2024

Further small refactorings for the resolver.

@konstin konstin added the internal A refactor or improvement that is not user-facing label Dec 10, 2024
charliermarsh
charliermarsh approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me as long as you're confident that behavior is unchanged.

@konstin konstin force-pushed the konsti/resolver-refactorings branch from 43e3c49 to 9dd9f9f Compare December 10, 2024 16:37
Base automatically changed from konsti/resolver-refactorings to main December 10, 2024 16:46
@konstin konstin changed the title Resolver module imporvements Resolver module improvements Dec 10, 2024
@konstin konstin force-pushed the konsti/resolver-refactoring2 branch 3 times, most recently from 7592ee3 to 24de627 Compare December 11, 2024 14:36
@konstin konstin enabled auto-merge (squash) December 11, 2024 14:37
@konstin konstin merged commit 509dc83 into main Dec 11, 2024
64 checks passed
@konstin konstin deleted the konsti/resolver-refactoring2 branch December 11, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konstin @charliermarsh