Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data out of bounds for alkox dataset #7

Open
matteoaldeghi opened this issue Dec 2, 2020 · 0 comments
Open

Data out of bounds for alkox dataset #7

matteoaldeghi opened this issue Dec 2, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@matteoaldeghi
Copy link
Collaborator

The alkox parameter space, defined in its config.json, does not match the data in the csv file. The temperature is expected to be between 60 and 140:

dataset = Dataset('alkox')
for param in dataset.param_space.parameters:
    print(param.name, param.low, param.high)
>>> residence_time 0.5 2.0
>>> ratio 1.0 5.0
>>> concentration 0.1 0.5
>>> temperature 60.0 140.0

But the csv file (dataset.data) contains temperatures between 6 and 8.

This results in the following error when the method set_param_space is called:

[ERROR] Lower bound of 0.5 provided for parameter `residence_time` is higher than minimum found in the data!
[ERROR] Lower bound of 1.0 provided for parameter `ratio` is higher than minimum found in the data!
[ERROR] Upper bound of 0.5 provided for parameter `concentration` is lower than maximum found in the data!
[ERROR] Lower bound of 60.0 provided for parameter `temperature` is higher than minimum found in the data!
@matteoaldeghi matteoaldeghi added the bug Something isn't working label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant