Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #10

Open
mseifrid opened this issue Apr 18, 2022 · 5 comments · Fixed by #11
Open

Testing #10

mseifrid opened this issue Apr 18, 2022 · 5 comments · Fixed by #11
Assignees
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@mseifrid
Copy link
Collaborator

Need to add tests

@mseifrid mseifrid added enhancement New feature or request invalid This doesn't seem right labels Apr 18, 2022
@mseifrid mseifrid self-assigned this Apr 18, 2022
@mseifrid
Copy link
Collaborator Author

Python 3.6 has issues with importing pytest==7.1.1. It can only find up to version 7.0.1.

@mseifrid
Copy link
Collaborator Author

Current snags

flake8 failing because of unused imports in tests/:

  • Easy fix.

pytest failing because it can't find chemspyd.utils 'module':

  • Hmmm. Probably fixable.

mypy failing because it thinks msvcrt doesn't have the kbhit() and getwch() methods:

  • This might be a tough one...

@mseifrid
Copy link
Collaborator Author

Python 3.6 has issues with importing pytest==7.1.1. It can only find up to version 7.0.1.

Removing version specs solved this issue

@mseifrid
Copy link
Collaborator Author

Current snags

flake8 failing because of unused imports in tests/:

  • Easy fix.

pytest failing because it can't find chemspyd.utils 'module':

  • Hmmm. Probably fixable.

mypy failing because it thinks msvcrt doesn't have the kbhit() and getwch() methods:

  • This might be a tough one...

flake8: Fixed by writing actual test, and commenting out imports in empty test files.

pytest: Fixed by adding pip install -r requirements.txt and pip install -e . to the tox testenv commands.

mypy: Fixed with # type: ignore for now, but will try to switch to a different library, e.g. keyboard or pynput.

@mseifrid
Copy link
Collaborator Author

pytest fails on local because the basetemp directory (from tox's envtmpdir) has spaces in it... Unclear how to remedy. Will probably just not run tox locally.

@mseifrid mseifrid linked a pull request Apr 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant