Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure 3 clarification from publication #6

Open
jessielyons opened this issue May 15, 2023 · 3 comments
Open

figure 3 clarification from publication #6

jessielyons opened this issue May 15, 2023 · 3 comments

Comments

@jessielyons
Copy link

Dear Authors,

Very nice publication.

  1. Can you please clarify how you plot the figure 3? Is training loss vs epoch plotted from dreaming or training. Since you mentioned target logp in figure as 3 or -3, i am guessing its from dreaming step.

  2. Can you please also clarify what is the meaning of logP vs epochs in figure 3? Is it from dreaming step? Can you share what are plotting from outputs generated? Are you using log file of the run or using "sampled_intermediate_mol" file for a particular target logp?

Any related code on how to generate Figure 3 can help.

Thanks so much,
JL

@MarioKrenn6240
Copy link
Contributor

ad1) yes, loss is from the dreaming process

ad2) logP is computed via RDKit (its for testing the ground truth of our system, and thats why its not a smooth function because we use onehot). Loss is the evolution of the loss during dreaming, which is the MSE between model prediction and target property.

The code for this is basically written in demo.py, let me know if this helps.

@MarioKrenn6240
Copy link
Contributor

Sure, you can just delete these lines, and it will work straightforwardly. The main idea is between line 283 and 300, so just go ahead and remove the rest and adjust the output of the dream function.

@jessielyons
Copy link
Author

jessielyons commented Jun 19, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants