Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PersistType needs to be added to @ArezComponent type which is difficult in react4j #4

Open
realityforge opened this issue May 21, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@realityforge
Copy link
Member

ArezPersist triggers the processing of a type when @PersistType is present on a type but it also checks to see whether the component has the @ArezComponent annotation and only generates the sidecar when that is present. (ArezPersist allows @Persist annotations on types annotated with @ActAsComponent but will generate errors in other circumstances but should not generate sidecars for @ActAsComponent types).

This does not work when another framework (like react4j) is responsible for creating the @ArezComponent type. We should figure out a way to have arbitrary frameworks allow and copy down annotations from other frameworks. i.e. Copy @PersistType on @ReactComponent annotated types to generated @ArezComponent and allow @Persist annotation to be present on @ReactComponent annotated types.

@realityforge
Copy link
Member Author

See arez/arez#112 for issue to track it across arez ecosystem

realityforge added a commit that referenced this issue May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant