-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Teaching Mode as a CLI Flag #2799
base: master
Are you sure you want to change the base?
Conversation
We're already logging every command executed into a file https://github.com/archlinux/archinstall/blob/040a6aba27d20361f0c833a04b75fce09690bb51/docs/help/report_bug.rst isn't that sufficient? |
I actually built this to educate myself about the arch install process, and to demonstrate to a fellow arch newb the patterns used by the guided installer. For me the I also envision the --teach option to be super easy to point newcomers to. For example: "Boot up this .iso, run these three iwctl commands to connect to WiFi, and then run |
Here's one more plug for @svartkanin Today I looked at the contents of
|
|
I agree. While it's a novel idea, I think it adds maintenance cost and some times generate a lot of noise (for instance when we probe devices for internal reasons, something users wouldn't have to do). If anything, I think we could be better about informing the users that IF they want to learn what we did - there is a file they can look at to track the steps - and that these steps can be further read about in the wiki. Because ultimately, these commands won't tell the user much unless they follow along the installation guide anyway. I like the idea tho, but I think we can achieve the same result with guiding the user to (we could probably improve this file too, if it's of use for others.. it's mainly for internal debugging and more advanced error debugging and can for sure contain sensitive information) |
PR Description:
Adds a flag through ArgParser for
--teach
, which does the following:Tests and Checks