Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password hashing uses an unverified algorithm #6

Open
dotnetchris opened this issue Aug 15, 2012 · 4 comments
Open

Password hashing uses an unverified algorithm #6

dotnetchris opened this issue Aug 15, 2012 · 4 comments

Comments

@dotnetchris
Copy link

PBKDF2 is the only verified implementation in .NET

http://stackoverflow.com/questions/481160/is-bcrypt-a-good-encryption-algorithm-to-use-in-c-where-can-i-find-it/6228051#6228051

@dotnetchris
Copy link
Author

If AppHarbor is very serious about this package it should either switch to PBKDF2 (what I recommend) otherwise it should proactively assume the burden and costs to have the BCrypt implementation verified such that AppHarbor.Web.Security can be viewed as truly secure for it's dependence on BCrypt.

@mehrdada
Copy link
Contributor

I want to point out that only the example project has a dependency on BCrypt. The base AppHarbor.Web.Security library itself does not.

@dotnetchris
Copy link
Author

If merely the sample uses BCrypt, I would strongly advocate switching to PBKDF2 in the sample. This will prevent users from following the sample and unknowingly open themselves up to liability for not using a verified algorithm (especially government software development)

@nberardi
Copy link
Contributor

@dotnetchris you can always submit a pull request to show how PBKDF2 would be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants