Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added firebird database type and parser module #33773

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Added firebird database type and parser module #33773

merged 2 commits into from
Nov 24, 2024

Conversation

TedCraft
Copy link
Contributor

@TedCraft TedCraft commented Nov 23, 2024 •
edited
Loading

Fixes #33699.

Changes proposed in this pull request:

  • Added Firebird related database type
  • Added Firebird related parser module
  • Added corresponding tests for Firebird database type and parser module

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@TedCraft TedCraft changed the title Add firebird datatype type and parser module Added firebird datatype type and parser module Nov 24, 2024
@TedCraft TedCraft changed the title Added firebird datatype type and parser module Added firebird database type and parser module Nov 24, 2024
@terrymanu
Copy link
Member

Great job, I will review soon.

@strongduanmu strongduanmu added this to the 5.5.2 milestone Nov 24, 2024
strongduanmu
strongduanmu approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so great, merged.

@strongduanmu strongduanmu merged commit f72ebcb into apache:master Nov 24, 2024
147 checks passed
@strongduanmu strongduanmu mentioned this pull request Nov 24, 2024
Merged
7 tasks
@TedCraft TedCraft deleted the shardingsphere-firebird branch November 24, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
db: Firebird type: new feature
Projects
None yet
Milestone
5.5.2
Development

Successfully merging this pull request may close these issues.

Proposal to Integrate Firebird Support into Apache ShardingSphere
3 participants
@TedCraft @terrymanu @strongduanmu