Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvemment](profile) use one counter to represent MemoryUsage and MemoryUsagePeak #44645

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

jacktengg
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@jacktengg
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40159 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2e75559144092abfba0ec9a1f51c6dbf413e352e, data reload: false

------ Round 1 ----------------------------------
q1	17680	7578	7289	7289
q2	2048	178	168	168
q3	10678	1082	1191	1082
q4	10371	718	721	718
q5	7615	2787	2735	2735
q6	240	149	148	148
q7	993	629	602	602
q8	9262	1835	1932	1835
q9	6558	6363	6364	6363
q10	7003	2356	2358	2356
q11	476	263	255	255
q12	415	216	221	216
q13	17810	3040	3048	3040
q14	240	208	218	208
q15	594	544	518	518
q16	670	587	594	587
q17	999	595	576	576
q18	7336	6705	6735	6705
q19	1336	994	1042	994
q20	476	183	177	177
q21	4182	3269	3271	3269
q22	391	321	318	318
Total cold run time: 107373 ms
Total hot run time: 40159 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7325	7264	7273	7264
q2	330	237	232	232
q3	2899	2855	2973	2855
q4	2080	1780	1908	1780
q5	5662	5727	5695	5695
q6	233	146	147	146
q7	2260	1843	1816	1816
q8	3430	3558	3509	3509
q9	8834	8970	8916	8916
q10	3582	3577	3560	3560
q11	609	522	524	522
q12	828	606	607	606
q13	12183	3266	3210	3210
q14	306	278	272	272
q15	575	524	533	524
q16	690	632	646	632
q17	1880	1640	1626	1626
q18	8314	7765	7630	7630
q19	1729	1602	1615	1602
q20	2107	1910	1876	1876
q21	5684	5436	5498	5436
q22	688	596	567	567
Total cold run time: 72228 ms
Total hot run time: 60276 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.34% (9974/26015)
Line Coverage: 29.43% (83460/283557)
Region Coverage: 28.59% (42965/150305)
Branch Coverage: 25.18% (21822/86650)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2e75559144092abfba0ec9a1f51c6dbf413e352e_2e75559144092abfba0ec9a1f51c6dbf413e352e/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 195639 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2e75559144092abfba0ec9a1f51c6dbf413e352e, data reload: false

query1	1227	943	965	943
query2	6234	2093	2056	2056
query3	10798	3871	3932	3871
query4	67386	28509	23408	23408
query5	4979	457	450	450
query6	414	183	198	183
query7	5632	303	295	295
query8	321	231	235	231
query9	9257	2738	2723	2723
query10	463	254	254	254
query11	17379	15346	15928	15346
query12	156	115	115	115
query13	1532	422	410	410
query14	10506	6842	7139	6842
query15	208	176	190	176
query16	7116	465	492	465
query17	1041	558	564	558
query18	2007	296	290	290
query19	208	161	155	155
query20	120	110	118	110
query21	218	114	105	105
query22	4897	4683	4631	4631
query23	34839	34363	33917	33917
query24	5490	2536	2438	2438
query25	482	380	430	380
query26	673	157	150	150
query27	2121	289	300	289
query28	4605	2540	2488	2488
query29	714	458	439	439
query30	216	152	153	152
query31	993	830	848	830
query32	71	62	59	59
query33	408	301	302	301
query34	927	516	526	516
query35	845	736	737	736
query36	1087	1016	955	955
query37	126	81	80	80
query38	4504	4455	4477	4455
query39	1525	1479	1473	1473
query40	200	129	97	97
query41	43	45	43	43
query42	109	96	101	96
query43	537	486	478	478
query44	1169	842	827	827
query45	185	173	174	173
query46	1156	691	718	691
query47	2023	1891	1941	1891
query48	436	326	338	326
query49	739	394	399	394
query50	862	390	399	390
query51	7397	7231	7123	7123
query52	99	84	85	84
query53	256	173	178	173
query54	507	383	392	383
query55	76	76	73	73
query56	253	249	243	243
query57	1336	1164	1162	1162
query58	213	202	219	202
query59	3102	3123	3031	3031
query60	259	246	243	243
query61	105	109	148	109
query62	782	665	669	665
query63	212	185	188	185
query64	1349	659	621	621
query65	3301	3167	3209	3167
query66	697	310	306	306
query67	16115	15570	15518	15518
query68	4014	562	557	557
query69	415	258	254	254
query70	1212	1140	1150	1140
query71	365	256	244	244
query72	6575	4122	3961	3961
query73	761	352	368	352
query74	10364	8966	9026	8966
query75	3409	2650	2657	2650
query76	1756	985	1033	985
query77	498	339	270	270
query78	10414	9327	9313	9313
query79	2291	590	590	590
query80	1363	419	431	419
query81	528	224	224	224
query82	1270	113	118	113
query83	189	148	145	145
query84	289	72	78	72
query85	1022	301	350	301
query86	414	312	312	312
query87	4748	4555	4730	4555
query88	3665	2221	2177	2177
query89	419	284	310	284
query90	1953	189	182	182
query91	134	99	114	99
query92	68	49	47	47
query93	2845	546	532	532
query94	826	268	262	262
query95	358	249	239	239
query96	632	278	269	269
query97	2893	2671	2716	2671
query98	214	202	207	202
query99	1763	1333	1283	1283
Total cold run time: 322910 ms
Total hot run time: 195639 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.32 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2e75559144092abfba0ec9a1f51c6dbf413e352e, data reload: false

query1	0.03	0.02	0.03
query2	0.07	0.03	0.03
query3	0.24	0.08	0.06
query4	1.60	0.11	0.11
query5	0.40	0.42	0.41
query6	1.15	0.66	0.64
query7	0.02	0.02	0.01
query8	0.03	0.04	0.03
query9	0.58	0.50	0.50
query10	0.55	0.55	0.57
query11	0.15	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.60	0.60
query14	2.70	2.87	2.75
query15	0.91	0.84	0.82
query16	0.38	0.38	0.38
query17	1.10	1.05	1.07
query18	0.22	0.21	0.21
query19	1.89	1.86	2.01
query20	0.01	0.01	0.01
query21	15.38	0.60	0.61
query22	2.71	2.71	1.49
query23	16.93	0.99	0.76
query24	2.83	2.01	2.10
query25	0.35	0.07	0.11
query26	0.54	0.14	0.14
query27	0.04	0.05	0.04
query28	9.12	1.10	1.10
query29	12.56	3.25	3.26
query30	0.25	0.05	0.06
query31	2.88	0.38	0.37
query32	3.26	0.46	0.47
query33	3.00	3.01	3.19
query34	17.01	4.44	4.48
query35	4.52	4.53	4.48
query36	0.67	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.02	0.03
query40	0.16	0.13	0.14
query41	0.08	0.03	0.03
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.31 s
Total hot run time: 33.32 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 27, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 5f8051a into apache:master Nov 29, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.x dev/3.0.x-conflict reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants