You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
https://github.com/apache/datafusion/raw/HEAD/datafusion/core/docs/source/_static/images/2x_bgwhite_original.png was found in crate.io. https://github.com/apache/datafusion/raw/HEAD/docs/source/_static/images/2x_bgwhite_original.png is the correct one.
The logo is missing because readme = "../../README.md" in datafusion/core/Cargo.toml.
If image ./static/image.png was specified, in this case crates.io resolve path to datafusion/core/static/image.png, but static/image.png is what we would like is static/image.png
Possible solution:
use absolute path
maintain a separate README.md for crate.io(create datafusion/core/README.md and readme = "./README.md")
I prefer first one, and I could open a PR if you agree.
Also, I thinks it's an good first issue, so I can also leave it to other if missing logo is not an serious problem
Describe the bug
https://crates.io/crates/datafusion/43.0.0 apache datafusion logo is missing
To Reproduce
not sure
Expected behavior
The logo should be like https://datafusion.apache.org/
Additional context
No response
The text was updated successfully, but these errors were encountered: