Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crates.io page has broken logo #13526

Open
alamb opened this issue Nov 22, 2024 · 2 comments
Open

crates.io page has broken logo #13526

alamb opened this issue Nov 22, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Nov 22, 2024

Describe the bug

https://crates.io/crates/datafusion/43.0.0 apache datafusion logo is missing

Screenshot 2024-11-22 at 9 58 38 AM

To Reproduce

not sure

Expected behavior

The logo should be like https://datafusion.apache.org/

Screenshot 2024-11-22 at 10 00 20 AM

Additional context

No response

@alamb alamb added the bug Something isn't working label Nov 22, 2024
@Eason0729
Copy link
Contributor

https://github.com/apache/datafusion/raw/HEAD/datafusion/core/docs/source/_static/images/2x_bgwhite_original.png was found in crate.io.
https://github.com/apache/datafusion/raw/HEAD/docs/source/_static/images/2x_bgwhite_original.png is the correct one.

The logo is missing because readme = "../../README.md" in datafusion/core/Cargo.toml.

If image ./static/image.png was specified, in this case crates.io resolve path to datafusion/core/static/image.png, but static/image.png is what we would like is static/image.png

Possible solution:

  1. use absolute path
  2. maintain a separate README.md for crate.io(create datafusion/core/README.md and readme = "./README.md")

I prefer first one, and I could open a PR if you agree.

Also, I thinks it's an good first issue, so I can also leave it to other if missing logo is not an serious problem

@alamb alamb added the good first issue Good for newcomers label Nov 26, 2024
@alamb
Copy link
Contributor Author

alamb commented Nov 26, 2024

I prefer first one, and I could open a PR if you agree.

I agree. Thank you 🐰

Also, I thinks it's an good first issue, so I can also leave it to other if missing logo is not an serious problem

Good call -- I added the tag. I defer to you if you want to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants