Verify TXT in the subdomain hierarchy #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `verify-dns-subdomains` flag, false by default. If set to true, when verifying the TXT records for a host, it will also traverse up the valid subdomains of the host and check if the fingerprint exists in any of them, to authenticate the request.
EpicEric
force-pushed
the
verify-dns-subdomains
branch
from
ef156fc to
c062d8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
verify-dns-subdomainsflag, false by default. If set to true, when verifying the TXT records for a host, it will also traverse up the valid subdomains of the host and check if the fingerprint exists in any of them, to authenticate the request.