-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: wait on upgrade does not wait #80
Comments
Greetings. Please update to 1.2.9 - the Upgrade process was enhanced in that version. |
Thanks a lot, 1.2.9 solves my issue. Sorry for not checking for an updated version myself. |
Seems I have not tested properly. Thought issue is solved but it is not. But issue only occurs on large major opnsense updates which take a lot of time (so in this case from OPNsense 24.1.3_1-amd64 to OPNsense 24.1.9_4-amd64). Playbook:
Result (Ansible Semaphore):
So opnsense instance gets still rebooted during upgrade process but too early, so when upgrade is still taking place and therefore breaks the opnsense instance. |
Wow 😲 That did never happen on my tests.. :/ Will check it as soon as possible |
I've not yet been able to reproduce your issue, but It seems logical that the box could be dead if it is rebootet while the upgrade is still running. However - I've (at least) added a warning to the module's documentation that recommends using the WebUI for upgrades. |
Thanks for looking into it. My only workaround for now is to have a hard pause of 10 minutes before the restart. So far a major update never took longer than 10 minutes...
So like this the upgrade always works but the playbook has a long run time in case of no or only minor updates. |
We now also perform a sanity check before performing any system-action - checking if the system is currently being upgraded (#97) |
Modules
ansibleguy.opnsense.system with action upgrade with option wait true and timeout 600
Version
Ansible Version
OPNSense Version
OPNSense-Plugin Version
Issue
We are using your opnsense ansible module to upgrade our opnsense instances. After the upgrade we would like to reboot the instance. But the wait option in the upgrade task does not really wait for the upgrade process and therefore the next step is executed which reboots the opnsense instance. On bigger upgrades this causes to break the opnsense instance since it get's rebooted while upgrading.
Expected result: wait for the upgrade to finish
result: reboot gets executed during upgrade
Upgrading from OPNsense 24.1.3_1-amd64 to OPNsense 24.1.9_4-amd64 takes around 5-10 minutes but it waits only for 1 minute
Config Ansible
Config OPNSense
Debug Output
Profiling Output
No response
The text was updated successfully, but these errors were encountered: