Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues #2

Open
zhangsong1213 opened this issue Dec 18, 2023 · 1 comment
Open

Some issues #2

zhangsong1213 opened this issue Dec 18, 2023 · 1 comment

Comments

@zhangsong1213
Copy link

Hello, thank you very much for sharing your code. However, I have noticed that some parts of the code do not align with the content of the paper.

  1. The code following PAdaIN does not match the paper content.
  2. I couldn't find the preprocessing method for generating reference images in the code.
  3. The balance module and stretch module involve convolution, and the convolution parameters need to be trained before use.
    Additionally, the essence of the paper is essentially based on supervised training using reference images, which is quite different from the title of the paper.
@alzayats
Copy link
Owner

Hello,

Thank you for your interest in our work and for taking the time to review our code. We appreciate your feedback and understand your concerns. Let me address them one by one:

  1. PAdaIN Code: The implementation of PAdaIN can be found in the file UDnet.py on lines 102-109. We believe this section of the code aligns with the content of the paper.

  2. Preprocessing Method: The preprocessing method for generating reference images is implemented in the file label_gen.py.

  3. Balance and Stretch Modules: The balance and stretch modules are trained online. This process is implemented on line 77 in the file UDnet.py.

  4. Supervised Training: The paper relies on auto-generated reference images without ground truth, see dataset.py lines 71-115.

We hope this clarifies your concerns. Please feel free to reach out if you have any more questions or suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants