Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favIconUrl is sometimes undefined on action (tab) (Firefox only?) #102

Open
kjeldahl opened this issue Dec 9, 2022 · 1 comment
Open

Comments

@kjeldahl
Copy link

kjeldahl commented Dec 9, 2022

In https://github.com/alyssaxuu/omni/blob/master/src/content.js#L72 the action.favIconUrl is sometime undefined for tab actions which will then cause a network request to /undefined.

It fails to load the image and the error handler shows the globe instead.

I guess it would be better to just show globe immediately when favIconUrl is undefined to avoid a failing request in the log.

I have only noticed this on Firefox (currently running v107.0.1 on Mac M1)

@kjeldahl kjeldahl changed the title favIconUrl is sometims undefined on action (tab) (Firefox only?) favIconUrl is sometimes undefined on action (tab) (Firefox only?) Dec 9, 2022
@mattsches
Copy link

I think I have the same issue here (Firefox, Ubuntu), and it's particularly annoying while developing/debugging web applications - the extra request really shouldn't happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants