Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can link to anchors from other pages #190

Open
billywardrop29 opened this issue Nov 23, 2019 · 5 comments
Open

Can link to anchors from other pages #190

billywardrop29 opened this issue Nov 23, 2019 · 5 comments

Comments

@billywardrop29
Copy link

billywardrop29 commented Nov 23, 2019

Hi

If I add a link such as http://dev.myeduapp.co.uk/#secondPage-edu to my FAQs page second question (http://dev.myeduapp.co.uk/faq) which points to my second

anchor, it still loads the first page. Then when I vertical scroll the anchor url in the address bar changes to the corrects anchors as you scroll. I have added the anchors as per your documentation but cant get it to work. What am I doing wrong?

I've attached my js and my url is
pagepiling.js.txt

Cheers

Billy

@alvarotrigo
Copy link
Owner

I can't reproduce the issue on the demo page, it seems to be working as expected there:
https://alvarotrigo.com/pagePiling/#page2

Can you please provide an isolated reproduction in jsfiddle or codepen, with no CSS or JS files external to pagePiling.js and the minimum amount of HTML code? Use empty sections unless strictly necessary for the reproduction.

Perhaps you might find useful to read my article regarding how to create isolated reproductions.

@gbrle
Copy link

gbrle commented Nov 27, 2019

Same problem, but just on Firefox & Safari.

Chrome and IE, its ok !

@alvarotrigo
Copy link
Owner

Sounds like you are probably missing this parts in the docs?

Be careful! data-anchor tags can not have the same value as any ID element on the site (or NAME element for IE).

@billywardrop29
Copy link
Author

Sorry I've not had a chance to set up in jsfiddle. Here is my code in action http://dev.myeduapp.co.uk/#firstPage-edu. I will try setup a demo in the next few days

@alvarotrigo
Copy link
Owner

I'll wait for the isolated reproduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants