Skip to content
This repository has been archived by the owner on Feb 12, 2020. It is now read-only.

add ability to include alternate Lemmas in morph display #166

Closed
balmas opened this issue Aug 16, 2018 · 6 comments
Closed

add ability to include alternate Lemmas in morph display #166

balmas opened this issue Aug 16, 2018 · 6 comments
Labels
bug Something isn't working verified passed qa

Comments

@balmas
Copy link
Member

balmas commented Aug 16, 2018

Per alpheios-project/data-models#42 and alpheios-project/morph-client#17 we sometimes have lexemes which have lemmas with alternate spellings. We need to show these under a single lexeme entry in the morph display, similar to the way we did in V1:

44033906-c7be422a-9ed9-11e8-8da5-92cdee83cdf7

@balmas balmas added the bug Something isn't working label Aug 16, 2018
balmas pushed a commit that referenced this issue Aug 16, 2018
@balmas balmas self-assigned this Aug 16, 2018
@balmas
Copy link
Member Author

balmas commented Aug 16, 2018

Starting work on this .. still remaining to be done:

  • sort lemmas on a lexeme by frequency
  • display source (if there is one) with each lemma

@balmas balmas mentioned this issue Aug 24, 2018
@balmas
Copy link
Member Author

balmas commented Aug 24, 2018

@monzug
Copy link

monzug commented Aug 27, 2018

everything works as per bug fixes. tested on Chrome. Firefox will be next

  1. can we update the link for irregular verb to go to a different section of the grammar? right now, it takes to part 2, Inflections. it should go to irregular verbs section 124
  2. what happened to the inflection tables for irregular verbs ? for absum is not in the verb drop-down

@monzug
Copy link

monzug commented Aug 27, 2018

in Firefox, when clicking on the verb conjugation link, the correct section of the grammar is displayed.
also in Firefox, the verb irregular for absum is not available in the verb dropdown. Is this because we don't have the inflection table for this verb?

@monzug monzug assigned balmas and unassigned monzug Aug 27, 2018
@balmas
Copy link
Member Author

balmas commented Aug 27, 2018

re 1: can you try clearing your browser cache in Chrome? I think likely the incorrect index file is cached, which is why you go to the wrong grammar entry there, and don't in Firefox

re 2: yes we don't have irregular tables for adsum yet -- we have an issue for that alpheios-project/inflection-tables#70 . I'm still trying to decide if I want to add the conjugations for all the compounds of sum or to just show the base sum table. I started adding the, but decided to check with you again about that first :-) see my comment in that item.

@monzug
Copy link

monzug commented Aug 28, 2018

you were right. I forgot to clear cache in Chrome. close this one.

@monzug monzug removed their assignment Aug 28, 2018
@balmas balmas added the verified passed qa label Aug 28, 2018
@balmas balmas removed their assignment Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified passed qa
Projects
None yet
Development

No branches or pull requests

2 participants